Quantcast

Review code before submitting it into Perforce

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Review code before submitting it into Perforce

Gary Yang

Hi,

We use Perforce. We want users to use CodeStriker to review their code before submission. Something like after the topic is reviewed and approved, then the developer is allowed to submit his code. Or, at least there is a CodeStriker ID exist for his code. Then he can submit his code into Perforce. Can someone tell me how to do that?

Thanks,


Gary



     

------------------------------------------------------------------------------
Register Now & Save for Velocity, the Web Performance & Operations
Conference from O'Reilly Media. Velocity features a full day of
expert-led, hands-on workshops and two days of sessions from industry
leaders in dedicated Performance & Operations tracks. Use code vel09scf
and Save an extra 15% before 5/3. http://p.sf.net/sfu/velocityconf
_______________________________________________
Codestriker-user mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/codestriker-user
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Review code before submitting it into Perforce

David Sitsky
Administrator
> We use Perforce. We want users to use CodeStriker to review their code before submission. Something like after the topic is reviewed and approved, then the developer is allowed to submit his code. Or, at least there is a CodeStriker ID exist for his code. Then he can submit his code into Perforce. Can someone tell me how to do that?

I'm not sure exactly what it is you are asking.. but there is no way
you can use Codestriker to prevent users from committing in code,
other than through agreements within your team.

In theory, you could possibly write an SCM hook pre-commit to check
that the topic ID they have entered in the SCM comment is in the
appropriate state, but I'm not sure if that's worth the trouble.

You can use a system like Codestriker + Bugzilla + ScmBug together to
provide more glue - in a sense, the Bugzilla ID becomes the ID you are
after.  We use ScmBug here at my work.  It has issues with moved files
under Subversion, but it seems to work reasonably well.

Cheers,
David

------------------------------------------------------------------------------
Register Now & Save for Velocity, the Web Performance & Operations
Conference from O'Reilly Media. Velocity features a full day of
expert-led, hands-on workshops and two days of sessions from industry
leaders in dedicated Performance & Operations tracks. Use code vel09scf
and Save an extra 15% before 5/3. http://p.sf.net/sfu/velocityconf
_______________________________________________
Codestriker-user mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/codestriker-user
Loading...